Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for ECR repositorires #244

Merged
merged 24 commits into from
Nov 29, 2024
Merged

Add suport for ECR repositorires #244

merged 24 commits into from
Nov 29, 2024

Conversation

scaps1
Copy link
Contributor

@scaps1 scaps1 commented Oct 23, 2024

Some users prefer to use in EKS clusters ECR without service accounts to authorize but with native support from ECR using IAM policies to provide credentials for their projects.
Exporter can't get any credentials from SA or from Secrets and falls with 401 Unauthorized exception.
This PR adds new libraries from AWS for work with their authorization methods.

Signed-off-by: alexey.komyakov <[email protected]>
@scaps1 scaps1 self-assigned this Oct 23, 2024
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
@scaps1 scaps1 marked this pull request as ready for review October 25, 2024 09:56
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
@scaps1 scaps1 marked this pull request as draft October 30, 2024 13:54
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
@scaps1 scaps1 requested a review from nabokihms November 8, 2024 09:44
@scaps1 scaps1 marked this pull request as ready for review November 8, 2024 09:44
pkg/registry/checker.go Outdated Show resolved Hide resolved
pkg/providers/k8s/k8s.go Outdated Show resolved Hide resolved
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/providers/provider.go Outdated Show resolved Hide resolved
pkg/providers/amazon/amazon.go Show resolved Hide resolved
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/registry/checker.go Outdated Show resolved Hide resolved
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
Signed-off-by: alexey.komyakov <[email protected]>
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/providers/amazon/amazon.go Show resolved Hide resolved
pkg/providers/amazon/amazon.go Outdated Show resolved Hide resolved
pkg/providers/provider.go Outdated Show resolved Hide resolved
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions, but we are almost there! In terms of correctness, I think it is a lot better now. Thank you for the fixes.

Signed-off-by: alexey.komyakov <[email protected]>
@nabokihms nabokihms merged commit 034851b into master Nov 29, 2024
8 checks passed
@nabokihms
Copy link
Member

well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants